Re: [PATCH v2 10/41] builtin/pack-objects.c: use die_errno() and warning_errno()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 3, 2016, 19:54 UTC
- Message-ID
- <xmqqeg9incih.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1462277054-5943-11-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> > ---
Show 6 quoted lines
> @@ -2020,7 +2018,7 @@ static void ll_find_deltas(struct object_entry **list, unsigned list_size,
> ret = pthread_create(&p[i].thread, NULL,
> threaded_find_deltas, &p[i]);
> if (ret)
> - die("unable to create thread: %s", strerror(ret));
> + die_errno("unable to create thread");This deserves a mention in the log message. pthread_create() returns 0 on success and it returns "an error number" on error. We used to format that returned value with strerror().
I do not see anywhere in the updated code that copies ret back to errno, which would mean die_errno() would use whatever happens to be in errno, and the relationship between the returned value 'ret' and the value that is in 'errno' at this point in the code is unclear to me.