Re: [PATCH 27/41] grep.c: use error_errno()

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 1, 2016, 18:46 UTC
Message-ID: <CAPig+cQ4hGKSG6aMkGTUPNs5+i3TOA66QmD97sSnMsR7DYsgbg@mail.gmail.com>
In-Reply-To: <1462101297-8610-28-git-send-email-pclouds@gmail.com>

On Sun, May 1, 2016 at 7:14 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 9 quoted lines

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> diff --git a/grep.c b/grep.c
> @@ -1732,7 +1732,7 @@ static int grep_source_load_file(struct grep_source *gs)
>         if (lstat(filename, &st) < 0) {
>         err_ret:
>                 if (errno != ENOENT)
> -                       error(_("'%s': %s"), filename, strerror(errno));
> +                       error_errno(_("'%s'"), filename);

Does this still need to be wrapped in _(...)? (Did it ever?)

Show 12 quoted lines

>                 return -1;
>         }
>         if (!S_ISREG(st.st_mode))
> @@ -1743,7 +1743,7 @@ static int grep_source_load_file(struct grep_source *gs)
>                 goto err_ret;
>         data = xmallocz(size);
>         if (st.st_size != read_in_full(i, data, size)) {
> -               error(_("'%s': short read %s"), filename, strerror(errno));
> +               error_errno(_("'%s': short read"), filename);
>                 close(i);
>                 free(data);
>                 return -1;