Re: [PATCH v2 12/41] builtin/update-index.c: prefer "err" to "errno" in process_lstat_error

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 3, 2016, 16:52 UTC
Message-ID: <CAPig+cRASxkmgRt_gK89-qtqVPuWzq5TynaXzBY4iqcCdo2Cqg@mail.gmail.com>
In-Reply-To: <1462277054-5943-13-git-send-email-pclouds@gmail.com>

On Tue, May 3, 2016 at 8:03 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

> "errno" is already passed in as "err". Here we should use err instead of
> errno. errno is probably a copy/paste mistake in e011054 (Teach
> git-update-index about gitlinks - 2007-04-12)

Thanks, this version is quite sensible and doesn't trigger any feelings of discomfort[1].

[1]: http://thread.gmane.org/gmane.comp.version-control.git/293150/focus=293205

Show 20 quoted lines

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  builtin/update-index.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/update-index.c b/builtin/update-index.c
> index 1c94ca5..b8b8522 100644
> --- a/builtin/update-index.c
> +++ b/builtin/update-index.c
> @@ -255,7 +255,7 @@ static int process_lstat_error(const char *path, int err)
>  {
>         if (err == ENOENT || err == ENOTDIR)
>                 return remove_one_path(path);
> -       return error("lstat(\"%s\"): %s", path, strerror(errno));
> +       return error("lstat(\"%s\"): %s", path, strerror(err));
>  }
>
>  static int add_one_path(const struct cache_entry *old, const char *path, int len, struct stat *st)
> --
> 2.8.0.rc0.210.gd302cd2