Re: [PATCH v2 00/13] format-patch: clean up tests and documentation

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 5, 2019, 19:56 UTC
Message-ID: <xmqqef0uplex.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190904112105.GA27933@archbookpro.localdomain>

Denton Liu <liu.denton@gmail.com> writes:

Show 7 quoted lines

> Hi Junio,
>
> I see that "dl/format-patch-doc-test-cleanup" currently has the comment
> "Expecting a reroll." This should be the reroll that you're expecting ;)
>
> Also, since there haven't been any comments on the topic in a while, I
> propose that it should be ready for inclusion.

I may be the only person who had issues applying that series from the list, with mixtures of iso-8859-1 and utf-8 causing troubles, but if I am not alone, I suspect that the reason why nobody gave a comment is because the patches did not even apply so there is nothing to base their comments on.

I wiggled them and compared the result. The range diff against what has been queued seems a bit different from what you gave below (e.g. I see log message got modified on patch #2 and the dropping of the comma made it harder to read), but the endpoint diff looks not too bad (IOW, the alloted time for the topic ran out before I started looking at each individual patches in more depth).