[PATCH v4 1/3] format-patch: remove erroneous and condition

From: Denton Liu <liu.denton@gmail.com>
Date: Oct 11, 2019, 19:12 UTC
Message-ID: <5fa7cbbd7a68eae76347b90371201e20cba1c381.1570821015.git.liu.denton@gmail.com>
In-Reply-To: <cover.1570821015.git.liu.denton@gmail.com>

Commit 30984ed2e9 (format-patch: support deep threading, 2009-02-19), introduced the following lines:

	#define THREAD_SHALLOW 1

	[...]

	thread = git_config_bool(var, value) && THREAD_SHALLOW;

Since git_config_bool() returns a bool, the trailing `&& THREAD_SHALLOW` is a no-op. Remove this erroneous and condition.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 builtin/log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/log.c b/builtin/log.c
index 44b10b3415..7d658cecef 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -835,7 +835,7 @@ static int git_format_config(const char *var, const char *value, void *cb)
 			thread = THREAD_SHALLOW;
 			return 0;
 		}
-		thread = git_config_bool(var, value) && THREAD_SHALLOW;
+		thread = git_config_bool(var, value);
 		return 0;
 	}
 	if (!strcmp(var, "format.signoff")) {

-- 
2.23.0.17.g7cce04acd6.dirty