Re: [PATCH 08/13] t4014: let sed open its own files

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 26, 2019, 00:42 UTC
Message-ID: <CAPig+cTBzxbEOo2tBOeTiYM8njDuAVTdBzATtPUmA6uMni4L-Q@mail.gmail.com>
In-Reply-To: <7d9a24a97972ab8a8a1cfe1f2605630e154886be.1566635008.git.liu.denton@gmail.com>

On Sat, Aug 24, 2019 at 4:27 AM Denton Liu <liu.denton@gmail.com> wrote:

> In some cases, we were using a redirection operator to feed input into
> sed. However, since sed is capable of opening its own files and provides
> better error messages on IO failure, make sed open its own files instead
> of redirecting input into it.

I don't care strongly one way or the other, but the justification of "better error message" is rather weak:

    % sed '/^$/d' <foo
    sh: foo: No such file or directory
    % sed '/^$/d' foo
    sed: foo: No such file or directory
    %

I doubt it's worth a re-roll, though.

> Signed-off-by: Denton Liu <liu.denton@gmail.com>

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.