git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Patch v1 2/3] strbuf.c: remove unreferenced strbuf_write_fd method.

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 19, 2020, 19:30 UTC
Message-ID
<xmqqeeqahmz7.fsf@gitster.c.googlers.com>
In-Reply-To
<20200619150445.4380-3-randall.s.becker@rogers.com>
randall.s.becker@rogers.com writes:
> From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
> strbuf_write_fd was only used in bugreport.c. Since that file now uses
> write_in_full, this method is no longer needed.
Yay!
Show 21 quoted lines
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
>  strbuf.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/strbuf.c b/strbuf.c
> index 2f1a7d3209..e3397cc4c7 100644
> --- a/strbuf.c
> +++ b/strbuf.c
> @@ -556,11 +556,6 @@ ssize_t strbuf_write(struct strbuf *sb, FILE *f)
>  	return sb->len ? fwrite(sb->buf, 1, sb->len, f) : 0;
>  }
>  
> -ssize_t strbuf_write_fd(struct strbuf *sb, int fd)
> -{
> -	return sb->len ? write(fd, sb->buf, sb->len) : 0;
> -}
> -
>  #define STRBUF_MAXLINK (2*PATH_MAX)
>  
>  int strbuf_readlink(struct strbuf *sb, const char *path, size_t hint)
Previous: randall.s.becker@rogers.comNext: Jeff King
Message 14 of 15 in “Replace strbuf_write_fd with write_in_full”
  1. 0/3 Replace strbuf_write_fd with write_in_fullrandall.s.becker@rogers.com, Jun 19, 2020
  2. 3/3 strbuf.h: remove declaration of deprecated strbuf_write_fd method.randall.s.becker@rogers.com, Jun 19, 2020
  3. Junio C HamanoJun 19, 2020
  4. Randall S. BeckerJun 19, 2020
  5. 1/3 bugreport.c: replace strbuf_write_fd with write_in_fullrandall.s.becker@rogers.com, Jun 19, 2020
  6. Đoàn Trần Công DanhJun 19, 2020
  7. Randall S. BeckerJun 19, 2020
  8. Junio C HamanoJun 19, 2020
  9. Randall S. BeckerJun 19, 2020
  10. Đoàn Trần Công DanhJun 19, 2020
  11. Randall S. BeckerJun 19, 2020
  12. Jeff KingJun 19, 2020
  13. 2/3 strbuf.c: remove unreferenced strbuf_write_fd method.randall.s.becker@rogers.com, Jun 19, 2020
  14. Junio C HamanoJun 19, 2020
  15. Jeff KingJun 19, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.