Re: [Patch v1 3/3] strbuf.h: remove declaration of deprecated strbuf_write_fd method.

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 19, 2020, 19:31 UTC
Message-ID: <xmqqa70yhmxz.fsf@gitster.c.googlers.com>
In-Reply-To: <20200619150445.4380-4-randall.s.becker@rogers.com>

randall.s.becker@rogers.com writes:

Show 6 quoted lines

> From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
>  strbuf.h | 1 -
>  1 file changed, 1 deletion(-)

I think this should be part of 2/3 (otherwise we'd have a decl that nobody references that declares a function that nobody implements).

Show 12 quoted lines

> diff --git a/strbuf.h b/strbuf.h
> index 7062eb6410..223ee2094a 100644
> --- a/strbuf.h
> +++ b/strbuf.h
> @@ -473,7 +473,6 @@ int strbuf_readlink(struct strbuf *sb, const char *path, size_t hint);
>   * NUL bytes.
>   */
>  ssize_t strbuf_write(struct strbuf *sb, FILE *stream);
> -ssize_t strbuf_write_fd(struct strbuf *sb, int fd);
>  
>  /**
>   * Read a line from a FILE *, overwriting the existing contents of