Re: [Patch v1 2/3] strbuf.c: remove unreferenced strbuf_write_fd method.

From: Jeff King <peff@peff.net>
Date: Jun 19, 2020, 19:49 UTC
Message-ID: <20200619194901.GB722967@coredump.intra.peff.net>
In-Reply-To: <20200619150445.4380-3-randall.s.becker@rogers.com>

On Fri, Jun 19, 2020 at 11:04:44AM -0400, randall.s.becker@rogers.com wrote:

> From: "Randall S. Becker" <rsbecker@nexbridge.com>
> 
> strbuf_write_fd was only used in bugreport.c. Since that file now uses
> write_in_full, this method is no longer needed.

Just because there are no callers _now_ does not necessarily mean that it's a good idea to get rid of a function. I think the real argument is that we don't expect new ones, because it's a badly designed function (for the reasons in our earlier discussion). Maybe worth summarizing here.

-Peff