Re: [PATCH 03/10] parse-options.[ch]: consistently use "enum parse_opt_result"

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 29, 2021, 00:12 UTC
Message-ID: <xmqqee98gryf.fsf@gitster.g>
In-Reply-To: <patch-03.10-fbcbaa47329-20210928T130905Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 7 quoted lines

> Use the "enum parse_opt_result" instead of an "int flags" as the
> return value of the applicable functions in parse-options.c.
>
> This will help catch future bugs, such as the missing "case" arms in
> the two existing users of the API in "blame.c" and "shortlog.c". A
> third caller in 309be813c9b (update-index: migrate to parse-options
> API, 2010-12-01) was already checking for these.

As I said, this one I am happy about. The previous step had a change related to this enum mixed in it (by mistake, I think), which belongs here instead.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.