Re: [PATCH v3] sparse index: fix use-after-free bug in cache_tree_verify()

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 7, 2021, 21:23 UTC
Message-ID: <xmqqee8wpm0u.fsf@gitster.g>
In-Reply-To: <pull.1053.v3.git.1633630041829.gitgitgadget@gmail.com>

"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 5 quoted lines

>      * Fixed the spelling of Stolee's name (sorry Stolee)
>      * Added "-q" to the test to prevent a failure on Microsoft's fork[1]
>     
>     [1]
>     https://lore.kernel.org/git/ebbe8616-0863-812b-e112-103680f7298b@gmail.com/

I've seen the exchange, but ...

> -	for OPERATION in "merge -m merge" cherry-pick rebase
> +	for OPERATION in "merge -m merge" cherry-pick "rebase --apply -q" "rebase --merge"
>  	do

... it looks too strange that only one of them requires a "--quiet" option. Is it a possibility to get whoever's fork corrected so that it behaves sensibly without requiring the "-q" option only for the particular rebase backend?

In the meantime, I'll queue the patch as-is (I actually queued the previous round with namefix already).

Thanks.