Re: [PATCH v2] sparse index: fix use-after-free bug in cache_tree_verify()

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Oct 7, 2021, 15:05 UTC
Message-ID: <028aef79-d4cd-5202-f657-4b5045f85d0f@gmail.com>
In-Reply-To: <3bf4e767-294e-0f30-f0bc-ffa706a86835@gmail.com>

Hi Stolee

On 07/10/2021 14:53, Derrick Stolee wrote:

Show 17 quoted lines

> On 10/7/2021 5:50 AM, Phillip Wood via GitGitGadget wrote:
>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
> ...
>> diff --git a/t/t1092-sparse-checkout-compatibility.sh b/t/t1092-sparse-checkout-compatibility.sh
>> index 886e78715fe..85d5279b33c 100755
>> --- a/t/t1092-sparse-checkout-compatibility.sh
>> +++ b/t/t1092-sparse-checkout-compatibility.sh
>> @@ -484,7 +484,7 @@ test_expect_success 'checkout and reset (mixed) [sparse]' '
>>   test_expect_success 'merge, cherry-pick, and rebase' '
>>   	init_repos &&
>>   
>> -	for OPERATION in "merge -m merge" cherry-pick rebase
>> +	for OPERATION in "merge -m merge" cherry-pick "rebase --apply" "rebase --merge"
> 
> I spoke too soon. On my machine, the 'git rebase --apply' tests fail
> because of some verbose output that does not match across the full
> and sparse cases. Using "rebase -q --apply" works for me.

Oh, that's strange, the CI tests pass on gitgitgadget and that script passes locally for me. Do you know what the output is that does not match?

Best Wishes

Phillip

> Thanks,
> -Stolee
>