Re: [PATCH v3] sparse index: fix use-after-free bug in cache_tree_verify()
- From
Bagas Sanjaya <bagasdotme@gmail.com>
- Date
- Oct 8, 2021, 09:38 UTC
- Message-ID
- <905e3d0f-0541-ffad-c05b-e7ebc6bed94c@gmail.com>
- In-Reply-To
- <pull.1053.v3.git.1633630041829.gitgitgadget@gmail.com>
On 08/10/21 01.07, Phillip Wood via GitGitGadget wrote:
Show 18 quoted lines
> -static void verify_one(struct repository *r,
> - struct index_state *istate,
> - struct cache_tree *it,
> - struct strbuf *path)
> +/*
> + * Returns:
> + * 0 - Verification completed.
> + * 1 - Restart verification - a call to ensure_full_index() freed the cache
> + * tree that is being verified and verification needs to be restarted from
> + * the new toplevel cache tree.
> + */
> +static int verify_one(struct repository *r,
> + struct index_state *istate,
> + struct cache_tree *it,
> + struct strbuf *path)
> {
> int i, pos, len = path->len;
> struct strbuf tree_buf = STRBUF_INIT;What is verify_one() doing? I think it worth mentioning it in the comment above.
-- An old man doll... just what I always wanted! - Clara