git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] Unify trailer formatting functions

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 15, 2024, 21:02 UTC
Message-ID
<xmqqedb6l4pw.fsf@gitster.g>
In-Reply-To
<owlyjzlg623v.fsf@fine.c.googlers.com>
Linus Arver <linusa@google.com> writes:
Show 16 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> "Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>
>>> This series is based on the initial series [1], notably the v4 version of
>>> patches 10-16 as suggested by Christian [2]. This version addresses the
>>> review comments for those patches, namely the avoidance of (temporary) test
>>> breakages.
>>
>> It has been 10 days but we haven't seen any reviews on this one.  It
>> could be that it did not get to intended mailboxes due to the header
>> corruption (I manually fixed in this message), but without reviews
>> we cannot move forward.
>
> Adding a couple more folks to the CC list according to the
> contrib/contacts/git-contacts script. Thanks!

As we saw no responses after two weeks, I took some time to scan these patches myself for the final time. I didn't see anything gravely wrong in it and am tempted to merge it down to 'next'.

Unless I hear objections in the next few days, that is.
Thanks.
Previous: Linus Arver
Message 16 of 16 in “Unify trailer formatting functions”
  1. 0/5 Unify trailer formatting functionsLinus Arver via GitGitGadget, Mar 15, 2024
  2. 1/5 format_trailer_info(): use trailer_item objectsLinus Arver via GitGitGadget, Mar 15, 2024
  3. 2/5 format_trailer_info(): drop redundant unfold_value()Linus Arver via GitGitGadget, Mar 15, 2024
  4. 3/5 format_trailer_info(): append newline for non-trailer linesLinus Arver via GitGitGadget, Mar 15, 2024
  5. Junio C HamanoMar 15, 2024
  6. 4/5 trailer: begin formatting unificationLinus Arver via GitGitGadget, Mar 15, 2024
  7. 5/5 trailer: finish formatting unificationLinus Arver via GitGitGadget, Mar 15, 2024
  8. Junio C HamanoMar 15, 2024
  9. Kristoffer HaugsbakkMar 15, 2024
  10. Junio C HamanoMar 15, 2024
  11. Linus ArverMar 15, 2024
  12. Junio C HamanoMar 15, 2024
  13. Johannes SchindelinJul 2, 2024
  14. Junio C HamanoMar 26, 2024
  15. Linus ArverApr 2, 2024
  16. Junio C HamanoApr 15, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.