git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] Unify trailer formatting functions

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 2, 2024, 09:37 UTC
Message-ID
<efdda91a-1118-ea54-d28f-dd6fa6df67c5@gmx.de>
In-Reply-To
<owly4jd741ph.fsf@fine.c.googlers.com>
Hi,
On Fri, 15 Mar 2024, Linus Arver wrote:
Show 41 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
> > Not about the series, but about the way it was sent.
> >
> > The messages in this series have exactly the same kind of breakages
> > in the recipient names/addresses we recently saw:
> >
> >     https://lore.kernel.org/git/xmqqh6hkxox6.fsf@gitster.g/
> >
> > Human-readable names with a SP inside [square bracket] pair
> > appended, and one of the addresses had that square bracket applied
> > inside <angle bracket> pair and breaking MTAs (I manually fixed
> > khaugsbakk's address before sending this response, so replying to
> > this messages should be OK).
>
> UGH, I'm so sorry about that.
>
> > What are you and Aryan's pull.1675.v3 did differently from other
> > series sent via GGG to trigger this, I have to wonder?
>
> I realize now that it's because I copy/pasted the "Cc: ..." lines in the PR
> description from
> https://github.com/gitgitgadget/git/pull/1632#issue-2068188239, such
> that when I pasted those in for the PR description for this series at
> https://github.com/gitgitgadget/git/pull/1694#issue-2187804953, it
> carried over the email addresses as Markdown-formatted hyperlinks.
> Currently it reads
>
>     Cc: Christian Couder [chriscool@tuxfamily.org](mailto:chriscool@tuxfamily.org)
>     Cc: Junio C Hamano [gitster@pobox.com](mailto:gitster@pobox.com)
>     Cc: Emily Shaffer [nasamuffin@google.com](mailto:nasamuffin@google.com)
>     cc: Josh Steadmon [steadmon@google.com](mailto:steadmon@google.com)
>     cc: Randall S. Becker [rsbecker@nexbridge.com](mailto:rsbecker@nexbridge.com)
>     cc: Christian Couder [christian.couder@gmail.com](mailto:christian.couder@gmail.com)
>     cc: "Kristoffer Haugsbakk" [code@khaugsbakk.name](mailto:code@khaugsbakk.name)
>     cc: "Kristoffer Haugsbakk" <code@khaugsbakk.name>
>
> when I click on "edit", where the last line must be from your manual fix
> which GGG picked up. I've cleaned up the PR description manually now,
> and for this message I'm also attempting to clean up those square
> brackets.

I would love to let myself be nerdsniped into working on this, alas, I cannot afford that before I learn the trick to stretch time.

So I did the next-best thing and jotted down pointers for any volunteer who wants to work on this: https://github.com/gitgitgadget/gitgitgadget/issues/1645#issuecomment-2202545542

Ciao, Johannes

Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 16 in “Unify trailer formatting functions”
  1. 0/5 Unify trailer formatting functionsLinus Arver via GitGitGadget, Mar 15, 2024
  2. 1/5 format_trailer_info(): use trailer_item objectsLinus Arver via GitGitGadget, Mar 15, 2024
  3. 2/5 format_trailer_info(): drop redundant unfold_value()Linus Arver via GitGitGadget, Mar 15, 2024
  4. 3/5 format_trailer_info(): append newline for non-trailer linesLinus Arver via GitGitGadget, Mar 15, 2024
  5. Junio C HamanoMar 15, 2024
  6. 4/5 trailer: begin formatting unificationLinus Arver via GitGitGadget, Mar 15, 2024
  7. 5/5 trailer: finish formatting unificationLinus Arver via GitGitGadget, Mar 15, 2024
  8. Junio C HamanoMar 15, 2024
  9. Kristoffer HaugsbakkMar 15, 2024
  10. Junio C HamanoMar 15, 2024
  11. Linus ArverMar 15, 2024
  12. Junio C HamanoMar 15, 2024
  13. Johannes SchindelinJul 2, 2024
  14. Junio C HamanoMar 26, 2024
  15. Linus ArverApr 2, 2024
  16. Junio C HamanoApr 15, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.