[PATCH 0/5] Unify trailer formatting functions
- From
- Linus Arver via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Mar 15, 2024, 06:55 UTC
- Message-ID
- <pull.1694.git.1710485706.gitgitgadget@gmail.com>
This series is based on the initial series [1], notably the v4 version of patches 10-16 as suggested by Christian [2]. This version addresses the review comments for those patches, namely the avoidance of (temporary) test breakages.
The central idea is to unify the functions format_trailer_info() and format_trailers() together (preferring the name of the latter), so that both the interpret-trailers built-in and format_trailers_from_commit() can call the same format_trailers() function, while maintaining feature parity.
[1] https://lore.kernel.org/git/pull.1632.v4.git.1707196348.gitgitgadget@gmail.com/ [2] https://lore.kernel.org/git/CAP8UFD08F0V13X0+CJ1uhMPzPWVMs2okGVMJch0DkQg5M3BWLA@mail.gmail.com/
Linus Arver (5): format_trailer_info(): use trailer_item objects format_trailer_info(): drop redundant unfold_value() format_trailer_info(): append newline for non-trailer lines trailer: begin formatting unification trailer: finish formatting unification
trailer.c | 81 ++++++++++++++++++++----------------------------------- trailer.h | 13 +++------ 2 files changed, 32 insertions(+), 62 deletions(-)
base-commit: 4f9b731bdeccffa1b13e5edf4bc0428b8d49704e Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1694%2Flistx%2Ftrailer-api-part-2-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1694/listx/trailer-api-part-2-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/1694
-- gitgitgadget