git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/5] Unify trailer formatting functions

From
LGLinus Arver via GitGitGadget <gitgitgadget@gmail.com>
Date
Mar 15, 2024, 06:55 UTC
Message-ID
<pull.1694.git.1710485706.gitgitgadget@gmail.com>

This series is based on the initial series [1], notably the v4 version of patches 10-16 as suggested by Christian [2]. This version addresses the review comments for those patches, namely the avoidance of (temporary) test breakages.

The central idea is to unify the functions format_trailer_info() and format_trailers() together (preferring the name of the latter), so that both the interpret-trailers built-in and format_trailers_from_commit() can call the same format_trailers() function, while maintaining feature parity.

[1] https://lore.kernel.org/git/pull.1632.v4.git.1707196348.gitgitgadget@gmail.com/ [2] https://lore.kernel.org/git/CAP8UFD08F0V13X0+CJ1uhMPzPWVMs2okGVMJch0DkQg5M3BWLA@mail.gmail.com/

Linus Arver (5):
  format_trailer_info(): use trailer_item objects
  format_trailer_info(): drop redundant unfold_value()
  format_trailer_info(): append newline for non-trailer lines
  trailer: begin formatting unification
  trailer: finish formatting unification
 trailer.c | 81 ++++++++++++++++++++-----------------------------------
 trailer.h | 13 +++------
 2 files changed, 32 insertions(+), 62 deletions(-)
base-commit: 4f9b731bdeccffa1b13e5edf4bc0428b8d49704e
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1694%2Flistx%2Ftrailer-api-part-2-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1694/listx/trailer-api-part-2-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1694
-- 
gitgitgadget
Next: Linus Arver via GitGitGadget
Message 1 of 16 in “Unify trailer formatting functions”
  1. 0/5 Unify trailer formatting functionsLinus Arver via GitGitGadget, Mar 15, 2024
  2. 1/5 format_trailer_info(): use trailer_item objectsLinus Arver via GitGitGadget, Mar 15, 2024
  3. 2/5 format_trailer_info(): drop redundant unfold_value()Linus Arver via GitGitGadget, Mar 15, 2024
  4. 3/5 format_trailer_info(): append newline for non-trailer linesLinus Arver via GitGitGadget, Mar 15, 2024
  5. Junio C HamanoMar 15, 2024
  6. 4/5 trailer: begin formatting unificationLinus Arver via GitGitGadget, Mar 15, 2024
  7. 5/5 trailer: finish formatting unificationLinus Arver via GitGitGadget, Mar 15, 2024
  8. Junio C HamanoMar 15, 2024
  9. Kristoffer HaugsbakkMar 15, 2024
  10. Junio C HamanoMar 15, 2024
  11. Linus ArverMar 15, 2024
  12. Junio C HamanoMar 15, 2024
  13. Johannes SchindelinJul 2, 2024
  14. Junio C HamanoMar 26, 2024
  15. Linus ArverApr 2, 2024
  16. Junio C HamanoApr 15, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.