Re: [PATCH v2] Makefile: set default goals in makefiles

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 18, 2025, 17:00 UTC
Message-ID: <xmqqeczvyyqr.fsf@gitster.g>
In-Reply-To: <Z7LZJ0tRz3iLPgmx@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 15 quoted lines

> On Sat, Feb 15, 2025 at 09:19:03PM +0000, Adam Dinwoodie wrote:
>> Explicitly set the default goal at the very top of various makefiles.
>> This is already present in some makefiles, but not all of them.
>> 
>> In particular, this corrects a regression introduced in a38edab7c8
>> (Makefile: generate doc versions via GIT-VERSION-GEN, 2024-12-06).  That
>> commit added some config files as build targets for the Documentation
>> directory, and put the target configuration in a sensible place.
>> Unfortunately, that sensible place was above any other build target
>> definitions, meaning the default goal changed to being those
>> configuration files only, rather than the HTML and man page
>> documentation.
>
> Thanks for the fix! The patch looks good to me, and I've double-checked
> that preexisting "all:" targets were all converted to "all::".

Thanks, both of you.  Will apply.