Re: [PATCH v2] Makefile: set default goals in makefiles
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Feb 17, 2025, 06:37 UTC
- Message-ID
- <Z7LZJ0tRz3iLPgmx@pks.im>
- In-Reply-To
- <20250215211904.41883-1-adam@dinwoodie.org>
On Sat, Feb 15, 2025 at 09:19:03PM +0000, Adam Dinwoodie wrote:
Show 11 quoted lines
> Explicitly set the default goal at the very top of various makefiles. > This is already present in some makefiles, but not all of them. > > In particular, this corrects a regression introduced in a38edab7c8 > (Makefile: generate doc versions via GIT-VERSION-GEN, 2024-12-06). That > commit added some config files as build targets for the Documentation > directory, and put the target configuration in a sensible place. > Unfortunately, that sensible place was above any other build target > definitions, meaning the default goal changed to being those > configuration files only, rather than the HTML and man page > documentation.
Thanks for the fix! The patch looks good to me, and I've double-checked that preexisting "all:" targets were all converted to "all::".
Patrick