git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: correct default docs build target

From
Adam Dinwoodie <adam@dinwoodie.org>
Date
Feb 14, 2025, 21:52 UTC
Message-ID
<20250214215717.2854453-1-adam@dinwoodie.org>

Put the "all" target definition near the top of Documentation/Makefile, so that attempts to run make in the documentation directory actually build the documentation.

This seems like the expected behaviour, and was the behaviour up until a38edab7c8 (Makefile: generate doc versions via GIT-VERSION-GEN, 2024-12-06). That commit added some config files as build targets, and put the configuration in a sensible place, but unfortunately that sensible place was above any other build target definitions, meaning the default goal changed to being those configuration files only.

Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>
---

Sending with my apologies to anyone who receives this twice; I made an error with my sendmail configuration, meaning servers checking the DMARC records would have rejected the previous patch.

 Documentation/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/Makefile b/Documentation/Makefile
index aedfe99d1d..31f40b6f37 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -3,6 +3,8 @@ include ../shared.mak
 
 .PHONY: FORCE
 
+all: html man
+
 # Guard against environment variables
 MAN1_TXT =
 MAN5_TXT =
@@ -238,8 +240,6 @@ DEFAULT_EDITOR_SQ = $(subst ','\'',$(DEFAULT_EDITOR))
 ASCIIDOC_EXTRA += -a 'git-default-editor=$(DEFAULT_EDITOR_SQ)'
 endif
 
-all: html man
-
 html: $(DOC_HTML)
 
 man: man1 man5 man7
-- 
2.47.0
Next: Junio C Hamano
Message 1 of 6 in “Makefile: correct default docs build target”
  1. Makefile: correct default docs build targetAdam Dinwoodie, Feb 14, 2025
  2. Junio C HamanoFeb 14, 2025
  3. Junio C HamanoFeb 14, 2025
  4. Makefile: set default goals in makefilesAdam Dinwoodie, Feb 15, 2025
  5. Patrick SteinhardtFeb 17, 2025
  6. Junio C HamanoFeb 18, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.