git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/2] t1300: test list with missing global config

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 6, 2026, 13:08 UTC
Message-ID
<xmqqeccym7k6.fsf@gitster.g>
In-Reply-To
<20261009-fix-config-list-global-home-and-xdg-v3-1-f936b9c8a0cc@microsoft.com>
Delilah Ashley Wu <delilahwu@linux.microsoft.com> writes:
Show 16 quoted lines
> From: Delilah Ashley Wu <delilahwu@microsoft.com>
>
> Record behaviour in two new tests: when no global configuration file
> exists, `git config list` succeeds whereas `git config list --global`
> fails. Only check the exit code, as we're not interested in the exact
> error message.
>
> This prevents regressions in the next patch, "config: read global scope
> via config_sequence", which modifies `do_git_config_sequence()` to
> optionally return a failure if no global configuration files were
> successfully read (i.e. when the `--global` flag is specified).
>
> Signed-off-by: Delilah Ashley Wu <delilahwu@microsoft.com>
> ---
>  t/t1300-config.sh | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
OK.
Show 19 quoted lines
> diff --git a/t/t1300-config.sh b/t/t1300-config.sh
> index e3f8064889..df8c14da0d 100755
> --- a/t/t1300-config.sh
> +++ b/t/t1300-config.sh
> @@ -2425,6 +2425,18 @@ test_expect_success '--show-scope with --default' '
>  	test_cmp expect actual
>  '
>  
> +test_expect_success 'list with nonexistent global config gracefully exits' '
> +	rm -f "$HOME"/.gitconfig "$HOME"/.config/git/config &&
> +	git config ${mode_prefix}list &&
> +	git config ${mode_prefix}list --show-scope
> +'
> +
> +test_expect_success 'list --global with nonexistent global config fails' '
> +	rm -f "$HOME"/.gitconfig "$HOME"/.config/git/config &&
> +	test_must_fail git config ${mode_prefix}list --global &&
> +	test_must_fail git config ${mode_prefix}list --global --show-scope
> +'

Do we know that XDG stuff is always ~/.config/git/config? Other tests that deal with XDG config files like t0007 seem to make sure XDG_CONFIG_HOME is at a place known to the tests by setting and exporting XDG_CONFIG_HOME; perhaps it does not matter?

>  test_expect_success 'override global and system config' '
>  	test_when_finished rm -f \"\$HOME\"/.gitconfig &&
>  	cat >"$HOME"/.gitconfig <<-EOF &&
Previous: Delilah Ashley WuNext: Delilah Ashley Wu
Message 30 of 32 in “config: read both home and xdg files for --global”
  1. 0/4 config: read both home and xdg files for --globalDelilah Ashley Wu via GitGitGadget, Oct 10, 2025
  2. 1/4 cleanup_path: force forward slashes on WindowsDelilah Ashley Wu via GitGitGadget, Oct 10, 2025
  3. Junio C HamanoNov 19, 2025
  4. 2/4 config: test home and xdg files in `list --global`Delilah Ashley Wu via GitGitGadget, Oct 10, 2025
  5. Junio C HamanoNov 19, 2025
  6. 3/4 config: read global scope via config_sequenceDelilah Ashley Wu via GitGitGadget, Oct 10, 2025
  7. Junio C HamanoNov 19, 2025
  8. 4/4 config: keep bailing on unreadable global filesDelilah Ashley Wu via GitGitGadget, Oct 10, 2025
  9. Kristoffer HaugsbakkOct 10, 2025
  10. Delilah Ashley WuNov 22, 2025
  11. Junio C HamanoJan 20, 2026
  12. Johannes SchindelinNov 17, 2025
  13. Junio C HamanoNov 18, 2025
  14. Junio C HamanoNov 19, 2025
  15. Delilah Ashley WuNov 22, 2025
  16. 0/3 config: read both home and xdg files for --globalDelilah Ashley Wu, Aug 23, 2026
  17. 2/3 config: let sequence require a successful fileDelilah Ashley Wu, Aug 23, 2026
  18. Junio C HamanoAug 26, 2026
  19. Delilah Ashley WuOct 9, 2026
  20. 1/3 path: use forward slashes in XDG config on WindowsDelilah Ashley Wu, Aug 23, 2026
  21. Junio C HamanoAug 26, 2026
  22. Delilah Ashley WuSep 10, 2026
  23. Delilah Ashley WuOct 9, 2026
  24. 3/3 config: read global scope via config_sequenceDelilah Ashley Wu, Aug 23, 2026
  25. Junio C HamanoAug 26, 2026
  26. Chris TorekAug 23, 2026
  27. Junio C HamanoAug 24, 2026
  28. 0/2 config: read both home and xdg files for --globalDelilah Ashley Wu, Oct 9, 2026
  29. 1/2 t1300: test list with missing global configDelilah Ashley Wu, Oct 9, 2026
  30. Junio C HamanoNov 6, 2026
  31. 2/2 config: read global scope via config_sequenceDelilah Ashley Wu, Oct 9, 2026
  32. Junio C HamanoNov 6, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.