Re: [PATCH/RFC 0/4] config: read both home and xdg files for --global

From: Delilah Ashley Wu <delilahwu@linux.microsoft.com>
Date: Nov 22, 2025, 02:00 UTC
Message-ID: <20251122020047.GB3947@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
In-Reply-To: <xmqqbjkyccae.fsf@gitster.g>

On Wed, Nov 19, 2025 at 06:44:25AM -0800, Junio C Hamano wrote:

Show 9 quoted lines

> "Delilah Ashley Wu via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
> 
> > As reported in [1]: `$HOME/.gitconfig` and `$XDG_CONFIG_HOME/git/config` are
> > both valid global config locations, but `git config list --global` only
> > includes the former in its output.
> 
> ... while "git config list" includes both, which is an inconsistency
> without good reason.

Good point! Will add above to the v2 cover letter.

> What is the reason behind [RFC] in the title?  Are there things that
> are iffy yourself in the patches that reviewers want to pay special
> attention to?

There wasn't any reason; I accidentally left the GitHub PR in draft mode when I submitted it. I'll drop the [RFC] in v2.

And thanks for the review! You covered the points that I also felt iffy about, e.g. introducing a regression in the middle of the patch series. I'll address your feedback in v2.

Delilah :)