git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] diffcore-rename with duplicate tree entries can segfault

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 24, 2015, 23:11 UTC
Message-ID
<xmqqd24yq517.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150224224918.GA24749@peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> I'm assuming there _is_ a sane sort order. We have two halves of a
> filepair, but I think before any of the rename or break detection kicks
> in, each pair should either:
>
>   1. Have a name in pair->one, and an invalid filespec in pair->two
>      (i.e., a deletion).
>
>   2. The opposite (name in pair->two, /dev/null in pair->one). An
>      addition.
>
>   3. The same name in pair->one and pair->two.

I think creation and deletion are expressed with mode=0 and not with /dev/null.

Previous: Jeff KingNext: Jeff King
Message 4 of 12 in “[BUG] diffcore-rename with duplicate tree entries can segfault”
  1. Jeff KingFeb 24, 2015
  2. Junio C HamanoFeb 24, 2015
  3. Jeff KingFeb 24, 2015
  4. Junio C HamanoFeb 24, 2015
  5. Jeff KingFeb 24, 2015
  6. Junio C HamanoFeb 25, 2015
  7. Jeff KingFeb 25, 2015
  8. Junio C HamanoFeb 25, 2015
  9. 0/2 diffcore-rename with duplicate tree entries can segfaultJeff King, Feb 27, 2015
  10. 1/2 diffcore-rename: split locate_rename_dst into two functionsJeff King, Feb 27, 2015
  11. 2/2 diffcore-rename: avoid processing duplicate destinationsJeff King, Feb 27, 2015
  12. Junio C HamanoFeb 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.