Re: [PATCH 2/2] diffcore-rename: avoid processing duplicate destinations

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 27, 2015, 21:48 UTC
Message-ID: <xmqqr3tbhvqc.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150227014227.GB3210@peff.net>

Jeff King <peff@peff.net> writes:

> Like I mentioned before, I'm OK with not checking the actual diff output
> in the test. It's not like it was planned, and is just what diff_tree()
> happens to produce.  It does make sense, though....

When the topic is on processing broken input, I do not think "It does make sense, though." is a primary point, unless the result expected by these tests is the only possibly sane outcome (otherwise, another equally-sensible output will be rejected as a test failure). So I agree that there is a possibility that we might regret having the diff output tested here in the future when somebody further works in the area.

But let's not worry too much about it for now.

Thanks; the solution seems reasonable.