From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 24 Feb 2015 23:11:00 GMT
Subject: Re: [BUG] diffcore-rename with duplicate tree entries can segfault
Message-ID: <xmqqd24yq517.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150224224918.GA24749@peff.net>

Jeff King <peff@peff.net> writes:

> I'm assuming there _is_ a sane sort order. We have two halves of a
> filepair, but I think before any of the rename or break detection kicks
> in, each pair should either:
>
>   1. Have a name in pair->one, and an invalid filespec in pair->two
>      (i.e., a deletion).
>
>   2. The opposite (name in pair->two, /dev/null in pair->one). An
>      addition.
>
>   3. The same name in pair->one and pair->two.

I think creation and deletion are expressed with mode=0 and not with
/dev/null.