git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/2] trailer: use fprintf instead of printf

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 13, 2016, 19:20 UTC
Message-ID
<xmqqd1t5nv6j.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<1452688989-13746-2-git-send-email-tklauser@distanz.ch>
Tobias Klauser <tklauser@distanz.ch> writes:
Show 5 quoted lines
> Use fprintf instead of printf in trailer.c in order to allow printing
> to a file other than stdout. This will be needed to support in-place
> editing in git interpret-trailers.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

Thanks. I won't bother to amend it myself or request you to reroll only for this, but that is a rather suboptimal title.

The distinction between fprintf/printf is an implementation detail; what you want to do in this change is to allow writing to a file other than the standard output, and that should be in the title.

Previous: Tobias KlauserNext: Tobias Klauser
Message 3 of 8 in “Add in-place editing support to git interpret-trailers”
  1. 0/2 Add in-place editing support to git interpret-trailersTobias Klauser, Jan 13, 2016
  2. 1/2 trailer: use fprintf instead of printfTobias Klauser, Jan 13, 2016
  3. Junio C HamanoJan 13, 2016
  4. Tobias KlauserJan 14, 2016
  5. 2/2 interpret-trailers: add option for in-place editingTobias Klauser, Jan 13, 2016
  6. Eric SunshineJan 13, 2016
  7. Tobias KlauserJan 14, 2016
  8. Matthieu MoyJan 13, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.