Re: [PATCH v3 1/2] trailer: use fprintf instead of printf

From: Tobias Klauser <tklauser@distanz.ch>
Date: Jan 14, 2016, 09:33 UTC
Message-ID: <20160114093345.GG26950@distanz.ch>
In-Reply-To: <xmqqd1t5nv6j.fsf@gitster.mtv.corp.google.com>

On 2016-01-13 at 20:20:04 +0100, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Tobias Klauser <tklauser@distanz.ch> writes:
> 
> > Use fprintf instead of printf in trailer.c in order to allow printing
> > to a file other than stdout. This will be needed to support in-place
> > editing in git interpret-trailers.
> >
> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> 
> Thanks.  I won't bother to amend it myself or request you to reroll
> only for this, but that is a rather suboptimal title.

Agree.

> The distinction between fprintf/printf is an implementation detail;
> what you want to do in this change is to allow writing to a file
> other than the standard output, and that should be in the title.

Since I'll do a v4 anyhow to address Eric's review comments, I can change the title in the reroll.

Thanks