From: Junio C Hamano Date: Wed, 13 Jan 2016 19:20:04 GMT Subject: Re: [PATCH v3 1/2] trailer: use fprintf instead of printf Message-ID: In-Reply-To: <1452688989-13746-2-git-send-email-tklauser@distanz.ch> Tobias Klauser writes: > Use fprintf instead of printf in trailer.c in order to allow printing > to a file other than stdout. This will be needed to support in-place > editing in git interpret-trailers. > > Signed-off-by: Tobias Klauser Thanks. I won't bother to amend it myself or request you to reroll only for this, but that is a rather suboptimal title. The distinction between fprintf/printf is an implementation detail; what you want to do in this change is to allow writing to a file other than the standard output, and that should be in the title.