Re: [PATCH 4/7] submodule-config: check if a submodule is in a group
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 11, 2016, 01:19 UTC
- Message-ID
- <xmqqd1otl7ca.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1462928397-1708-5-git-send-email-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
Show 6 quoted lines
> +static int in_group(int argc, const char **argv, const char *prefix)
> + ...
> + if (!group)
> + list = git_config_get_value_multi("submodule.updateGroup");
> + else {
> + string_list_split(&actual_list, group, ',', -1);Is this expected to be used only by test scripts, or will it have real scripted Porcelain as its users? I am wondering if concatenation with ' ' would be more natural if it is the latter (if only used for testing, I don't care that much).