Re: [PATCH 0/7] submodule groups

From: Junio C Hamano <gitster@pobox.com>
Date: May 11, 2016, 23:48 UTC
Message-ID: <xmqqh9e4i2av.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqlh3gi2qr.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 6 quoted lines

>>   git ls-files . :(file-size:>1024k)
>
> I somehow do not think this is a way normal people (read: end users)
> would want to interact with Git.  Pathspec is about "paths" and
> various ways to match them.  It is not about contents that happens
> to be currently named by that path.  Don't tie types or sizes to it.

To clarify, think what that non-pathspec means when used like this:

    $ git diff :(size>1M)
    $ git log --follow :(size>1M)

Which side of comparison does the "size" thing apply? Either, both, randomly? More importantly, what use case of users do these commands serve?

That is why I said that pathspec should never consider anything but the pathname string you see.