From: Junio C Hamano Date: Wed, 11 May 2016 01:19:17 GMT Subject: Re: [PATCH 4/7] submodule-config: check if a submodule is in a group Message-ID: In-Reply-To: <1462928397-1708-5-git-send-email-sbeller@google.com> Stefan Beller writes: > +static int in_group(int argc, const char **argv, const char *prefix) > + ... > + if (!group) > + list = git_config_get_value_multi("submodule.updateGroup"); > + else { > + string_list_split(&actual_list, group, ',', -1); Is this expected to be used only by test scripts, or will it have real scripted Porcelain as its users? I am wondering if concatenation with ' ' would be more natural if it is the latter (if only used for testing, I don't care that much).