Re: [PATCH 1/1] git-p4: correct hasBranchPrefix verbose output

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 22, 2016, 18:38 UTC
Message-ID: <xmqqd1n9m5m0.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1466587571-18532-1-git-send-email-aoakley@roku.com>

Andrew Oakley <aoakley@roku.com> writes:

Show 5 quoted lines

> The logic here was inverted, you got a message saying the file is
> ignored for each file that is not ignored.
>
> Signed-off-by: Andrew Oakley <aoakley@roku.com>
> ---

Thanks.

Show 15 quoted lines

>  git-p4.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-p4.py b/git-p4.py
> index b6593cf..b123aa2 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -2674,7 +2674,7 @@ class P4Sync(Command, P4UserMap):
>              return True
>          hasPrefix = [p for p in self.branchPrefixes
>                          if p4PathStartsWith(path, p)]
> -        if hasPrefix and self.verbose:
> +        if not hasPrefix and self.verbose:
>              print('Ignoring file outside of prefix: {0}'.format(path))
>          return hasPrefix