git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/1] git-p4: correct hasBranchPrefix verbose output

From
Andrew Oakley <aoakley@roku.com>
Date
Jun 21, 2016, 13:53 UTC
Message-ID
<1466517222-12600-1-git-send-email-aoakley@roku.com>
The logic here was inverted, you got a message saying the file is
ignored for each file that is not ignored.
---
 git-p4.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-p4.py b/git-p4.py
index b6593cf..b123aa2 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -2674,7 +2674,7 @@ class P4Sync(Command, P4UserMap):
             return True
         hasPrefix = [p for p in self.branchPrefixes
                         if p4PathStartsWith(path, p)]
-        if hasPrefix and self.verbose:
+        if not hasPrefix and self.verbose:
             print('Ignoring file outside of prefix: {0}'.format(path))
         return hasPrefix
 
-- 
2.7.3
Next: Lars Schneider
Message 1 of 6 in “git-p4: correct hasBranchPrefix verbose output”
  1. 1/1 git-p4: correct hasBranchPrefix verbose outputAndrew Oakley, Jun 21, 2016
  2. Lars SchneiderJun 21, 2016
  3. Junio C HamanoJun 21, 2016
  4. Andrew OakleyJun 22, 2016
  5. 1/1 git-p4: correct hasBranchPrefix verbose outputAndrew Oakley, Jun 22, 2016
  6. Junio C HamanoJun 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.