git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] git-p4: correct hasBranchPrefix verbose output

From
Lars Schneider <larsxschneider@gmail.com>
Date
Jun 21, 2016, 18:05 UTC
Message-ID
<C471957C-3FEE-4CEB-8940-624F73784355@gmail.com>
In-Reply-To
<1466517222-12600-1-git-send-email-aoakley@roku.com>
Show 18 quoted lines
> On 21 Jun 2016, at 15:53, Andrew Oakley <aoakley@roku.com> wrote:
> 
> The logic here was inverted, you got a message saying the file is
> ignored for each file that is not ignored.
> ---
> git-p4.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/git-p4.py b/git-p4.py
> index b6593cf..b123aa2 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -2674,7 +2674,7 @@ class P4Sync(Command, P4UserMap):
>             return True
>         hasPrefix = [p for p in self.branchPrefixes
>                         if p4PathStartsWith(path, p)]
> -        if hasPrefix and self.verbose:
> +        if not hasPrefix and self.verbose:
Thanks Andrew! Your fix is correct.
- Lars
Show 10 quoted lines
>             print('Ignoring file outside of prefix: {0}'.format(path))
>         return hasPrefix
> 
> -- 
> 2.7.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous: Andrew OakleyNext: Junio C Hamano
Message 2 of 6 in “git-p4: correct hasBranchPrefix verbose output”
  1. 1/1 git-p4: correct hasBranchPrefix verbose outputAndrew Oakley, Jun 21, 2016
  2. Lars SchneiderJun 21, 2016
  3. Junio C HamanoJun 21, 2016
  4. Andrew OakleyJun 22, 2016
  5. 1/1 git-p4: correct hasBranchPrefix verbose outputAndrew Oakley, Jun 22, 2016
  6. Junio C HamanoJun 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.