Re: body-CC-comment regression
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 17, 2017, 18:18 UTC
- Message-ID
- <xmqqd1egu1dl.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <vpq4lzs7o0s.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 26 quoted lines
>> On Fri, Feb 17, 2017 at 02:16:42PM +0100, Matthieu Moy wrote: > ... > If I had a time machine, I'd probably go back then and forbid multiple > addresses there, but ... > >> There does not seem to be single commit in the kernel where multiple >> address are specified in a CC tag since after git-send-email started >> allowing it, but there are ten commits before (to my surprise), and that >> should be contrasted with at least 4178 commits with trailing comments >> including a # sign. > > Hey, there's a life outside the kernel ;-). > ... >>> 1) Stop calling Mail::Address even if available.[...] >> >> Right, that sounds like the right thing to do regardless. >> >>> 2) Modify our in-house parser to discard garbage after the >. [...] >> >> Sounds perfectly fine to me, and seems to work too after quick test. > > OK, sounds like the way to go. > > Do you want to work on a patch? If not, I should be able to do that > myself. The code changes are straightforward, but we probably want a > proper test for that.
The true headers and the things at the bottom seem to be handled in a separate loop in send-email, so treating Cc: found in the former and in the latter differently should be doable. I think it is OK to explicitly treat the latter as "these are not e-mail addresses, but just a single e-mail address possibly with non-address cruft", without losing the ability to have more than one addresses on a single CC: e-mail header.