Re: body-CC-comment regression

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Feb 17, 2017, 17:38 UTC
Message-ID: <CA+55aFxPsRXKn=4jXUdPy1hh3iHagjoxMcpA5K-ENA-NtdnF-A@mail.gmail.com>
In-Reply-To: <vpq7f4pdkjp.fsf@anie.imag.fr>

On Fri, Feb 17, 2017 at 5:16 AM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

>
> I mostly agree for the SoB, but why should a Cc tag have only one email?

Because changing that clearly broke real and useful behavior.

The "multiple email addresses"  thing is bogus and wrong. Just don't do it.

How would you even parse it sanely? Are the Cc: lines now SMTP-compliant with the whole escaping and all the usual "next line" rules?

For example, in email, the rule for "next line" is that if you're in a header block, and it starts with whitespace, then it's a continuation of the last line.

That's *not* how Cc: lines work in commit messages. They are all individual lines, and we have lots of tools (mainly just scripts with grepping) that simply depend on it.

So this notion that the bottom of the commit message is some email header crap is WRONG.

Stop it. It caused bugs. It's wrong. Don't do it.

               Linus