Re: [PATCH v2] send-email: only allow one address per body tag

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Feb 20, 2017, 12:10 UTC
Message-ID: <vpqo9xxkqqo.fsf@anie.imag.fr>
In-Reply-To: <20170220114406.19436-1-johan@kernel.org>

Johan Hovold <johan@kernel.org> writes:

Show 8 quoted lines

> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1563,7 +1563,7 @@ foreach my $t (@files) {
>  	# Now parse the message body
>  	while(<$fh>) {
>  		$message .=  $_;
> -		if (/^(Signed-off-by|Cc): (.*)$/i) {
> +		if (/^(Signed-off-by|Cc): ([^>]*>?)/i) {

I think this is acceptable, but this doesn't work with trailers like

Cc: "Some > Body" <Some.Body@example.com>

A proper management of this kind of weird address should be doable by reusing the regexp parsing "..." in parse_mailbox:

	my $re_quote = qr/"(?:[^\"\\]|\\.)*"/;

So the final regex would look like

if (/^(Signed-off-by|Cc): (([^>]*|"(?:[^\"\\]|\\.)*")>?)/i) {

I don't think that should block the patch inclusion, but it may be worth considering.

Anyway, thanks for the patch!

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/