Re: [PATCH v3 10/10] fsck: test and document unknown fsck.<msg-id> values

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 30, 2018, 14:47 UTC
Message-ID: <xmqqd0v4kcfd.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <8736w3v51a.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 10 quoted lines

>>> When fsck.<msg-id> is set to an unknown value it'll cause "fsck" to
>>> die, but the same is not rue of the "fetch" and "receive"
>>> variants. Document this and test for it.
> ...
> We could change it. This is just something I ran into and figured it
> should be tested / documented, and didn't feel any need to change it
> myself.
>
> The current behavior is probably more of an organically grown
> accident. Maybe we should make all of these warn.

Or die. I do agree with your assessment that the discrepancy was not designed, and my inclination for a correctness-centered feature like fsck is to err on the side of caution, rather than letting a misconfiguration pass unintended kinds of breakages through.

Thanks.