Re: [PATCH v3 07/10] fetch: implement fetch.fsck.*

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 27, 2018, 20:18 UTC
Message-ID: <xmqq6010mo03.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180727143720.14948-8-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

>  +
>  Setting `fsck.<msg-id>` will be picked up by linkgit:git-fsck[1], but
> -to accept pushes of such data set `receive.fsck.<msg-id>` instead.
> +to accept pushes of such data set `receive.fsck.<msg-id>` instead, or

Inherited from the original, but I find it a lot more readable to write "to accept pushes of such data, set X" with a comma, given especially that "data set" is a noun that has little to do with what this sentence wants to talk about.

I'd suggest doing s/instead/& to loosen the error checking/ or something, as you are only talking about "to accept" (iow, the target audience is not those who want to reject more by promoting "warn" to "error"---you are talking to those who are only interested in demoting "error" to "warn" or "ignore").

> +to clone or fetch it set `fetch.fsck.<msg-id>`.

It is unclear to me what "it" in the last sentence refers to.

The best rewrite I came up with is "... to clone or fetch from a repository with such data" but that is not an exact counterpart to "to accept pushes of such data", so I am hesitant to suggest it.

"... to accept such data when fetching or cloning" might be a better counterpart, but repeated "to accept" in this single sentence bothers me somewhat. I dunno.

I'll comment on the implementation part of this patch after lunch. Thanks for working on this.