Re: [PATCH 1/1] Highlight keywords in remote sideband output.

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 31, 2018, 14:59 UTC
Message-ID: <xmqqd0v3e9iz.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAFQ2z_NL+8LVmv+E4osq2+nx+qVE4P80it8vjLUwib=HJ5k4Lg@mail.gmail.com>

Han-Wen Nienhuys <hanwen@google.com> writes:

Show 7 quoted lines

> On Mon, Jul 30, 2018 at 11:39 PM Junio C Hamano <gitster@pobox.com> wrote:
>> > + */
>> > +void maybe_colorize_sideband(struct strbuf *dest, const char *src, int n)
>>
>> I'll make this "static" to this file while queuing.
>
> Does that mean the patch is in?

It depends on your definition of "is in".

It does not mean there is no need to update it further before it graduates to 'master' and becomes part of the next release, if that is what you are asking.

I saw others commented on the patch, showing general interest in the feature, agreeing to the approach taken and suggesting improvements. I am *not* going to respond to these comments and make further changes myself (you hopefully will), but expect that these review discussions to find a good terminal point that results in your sending out the "hopefully the final best version" in some time. In the meantime while I am waiting for that, I'd hold onto the version posted here and build it with all topics in flight that are waiting for improvements in a similar way by merging it in the 'pu' branch. And while doing so, I'll minimally modify this initial version so that the whole thing at least compiles, by making small tweaks like making a function that should be static static and getting rid of decl-after-stmt, etc.

That is what I meant by that line, and nothing more.

Thanks.