Re: [PATCH 1/1] Highlight keywords in remote sideband output.

From: Duy Nguyen <pclouds@gmail.com>
Date: Jul 30, 2018, 14:52 UTC
Message-ID: <CACsJy8CSh5uqWepdY7wCzP024WYcRFM719uXoKzJ4oziHHxwjw@mail.gmail.com>
In-Reply-To: <20180730123334.65186-2-hanwen@google.com>

On Mon, Jul 30, 2018 at 2:34 PM Han-Wen Nienhuys <hanwen@google.com> wrote:

Show 9 quoted lines

> +       struct kwtable {
> +               const char *keyword;
> +               const char *color;
> +       } keywords[] = {
> +               {"hint", GIT_COLOR_YELLOW},
> +               {"warning", GIT_COLOR_BOLD_YELLOW},
> +               {"success", GIT_COLOR_BOLD_GREEN},
> +               {"error", GIT_COLOR_BOLD_RED},
> +       };

Please let me customize these colors. "grep color.*slot Documentation/config.txt help.c" could give you a few examples.

I think we also add a space after { and before } in most places (there are a few places that don't do that, but personally I'd prefer spaces to make it a bit easier to read).

-- 
Duy