Re: [PATCH 1/1] Highlight keywords in remote sideband output.

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Jul 31, 2018, 01:03 UTC
Message-ID: <20180731010312.GA45452@genre.crustytoothpaste.net>
In-Reply-To: <CACsJy8CSh5uqWepdY7wCzP024WYcRFM719uXoKzJ4oziHHxwjw@mail.gmail.com>

On Mon, Jul 30, 2018 at 04:52:40PM +0200, Duy Nguyen wrote:

Show 13 quoted lines

> On Mon, Jul 30, 2018 at 2:34 PM Han-Wen Nienhuys <hanwen@google.com> wrote:
> > +       struct kwtable {
> > +               const char *keyword;
> > +               const char *color;
> > +       } keywords[] = {
> > +               {"hint", GIT_COLOR_YELLOW},
> > +               {"warning", GIT_COLOR_BOLD_YELLOW},
> > +               {"success", GIT_COLOR_BOLD_GREEN},
> > +               {"error", GIT_COLOR_BOLD_RED},
> > +       };
> 
> Please let me customize these colors. "grep color.*slot
> Documentation/config.txt help.c" could give you a few examples.

Yes, please. I use a transparent terminal and I have trouble seeing the default red in some cases due to lack of contrast, and some people with certain forms of colorblindness may be unable to distinguish these three colors at all.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204