Re: [PATCH 3/4] t7401: ensure uniformity in the '--for-status' test

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 5, 2020, 22:25 UTC
Message-ID: <xmqqd044n31u.fsf@gitster.c.googlers.com>
In-Reply-To: <20200805210104.GH9546@syl.lan>

Taylor Blau <me@ttaylorr.com> writes:

Show 15 quoted lines

>>  test_expect_success '--for-status' "
>>  	git submodule summary --for-status HEAD^ >actual &&
>> -	test_i18ncmp actual - <<EOF
>> +	cat >expected <<-EOF &&
>>  * sm1 $head6...0000000:
>>
>>  * sm2 0000000...$head7 (2):
>>    > Add foo9
>>
>>  EOF
>> +	test_i18ncmp expected actual
>>  "
>
> I think that this is on the right track, but you can use a '<<-\EOF'
> here instead of '<<-EOF' to make the tabulation a little more flexible.

You are correct that the patch could have indented the here-doc and the line with EOF with a tab to make it easier to read.

The leading '-' after '<<' is what controls tabulation, so <<-EOF as written in the patch is good enough; you do not want to quote it further, because $head6 wants to be interpolated.