[PATCH v2 1/4] t7401: modernize style
- From
Shourya Shukla <shouryashukla.oo@gmail.com>
- Date
- Aug 12, 2020, 19:27 UTC
- Message-ID
- <20200812192737.13971-2-shouryashukla.oo@gmail.com>
- In-Reply-To
- <20200812192737.13971-1-shouryashukla.oo@gmail.com>
The tests in 't7401-submodule-summary.sh' were written a long time ago and has a violation with respect to our CodingGuidelines which is, incorrect spacing in usages of the redirection operator. Using a Git command in the upstream of a pipe might result in us losing its exit code. So, convert such usages so that they write to a file and read from them.
Mentored-by: Christian Couder <chriscool@tuxfamily.org> Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> Helped-by: Denton Liu <liu.denton@gmail.com> Helped-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com> --- t/t7401-submodule-summary.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh index 9bc841d085..8ee78bcb69 100755 --- a/t/t7401-submodule-summary.sh +++ b/t/t7401-submodule-summary.sh @@ -16,12 +16,13 @@ add_file () { owd=$(pwd) cd "$sm" for name; do - echo "$name" > "$name" && + echo "$name" >"$name" && git add "$name" && test_tick && git commit -m "Add $name" done >/dev/null - git rev-parse --verify HEAD | cut -c1-7 + git rev-parse --verify HEAD >out && + cut -c1-7 out cd "$owd" } commit_file () { @@ -125,7 +126,8 @@ commit_file sm1 && head3=$( cd sm1 && git reset --hard HEAD~2 >/dev/null && - git rev-parse --verify HEAD | cut -c1-7 + git rev-parse --verify HEAD >out && + cut -c1-7 out ) test_expect_success 'modified submodule(backward)' "
-- 2.28.0