git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 7/7] bisect--helper: retire `--check-and-set-terms` subcommand

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 29, 2021, 00:49 UTC
Message-ID
<xmqqczxova6g.fsf@gitster.c.googlers.com>
In-Reply-To
<20210125191710.45161-8-mirucam@gmail.com>
Miriam Rubio <mirucam@gmail.com> writes:
Show 5 quoted lines
> From: Pranit Bauva <pranit.bauva@gmail.com>
>
> The `--check-and-set-terms` subcommand is no longer from the
> git-bisect.sh shell script. Instead the function
> `check_and_set_terms()` is called from the C implementation.
Nice to see these intermediate state going away.

Reviewers and mentors, how close do you folks think these patches are to the completion? It looks quite good to me (admittedly I gave only a cursory look to these recent iterations).

Thanks.
Previous: Miriam RubioNext: Miriam Rubio
Message 6 of 19 in “Finish converting git bisect to C part 3”
  1. 0/7 Finish converting git bisect to C part 3Miriam Rubio, Jan 25, 2021
  2. 1/7 bisect--helper: reimplement `bisect_log` shell function in CMiriam Rubio, Jan 25, 2021
  3. Đoàn Trần Công DanhJan 30, 2021
  4. Christian CouderJan 30, 2021
  5. 7/7 bisect--helper: retire `--check-and-set-terms` subcommandMiriam Rubio, Jan 25, 2021
  6. Junio C HamanoJan 29, 2021
  7. 4/7 bisect--helper: use `res` instead of return in BISECT_RESET case optionMiriam Rubio, Jan 25, 2021
  8. Christian CouderJan 29, 2021
  9. 6/7 bisect--helper: reimplement `bisect_skip` shell function in CMiriam Rubio, Jan 25, 2021
  10. 5/7 bisect--helper: retire `--bisect-auto-next` subcommandMiriam Rubio, Jan 25, 2021
  11. 3/7 bisect--helper: retire `--bisect-write` subcommandMiriam Rubio, Jan 25, 2021
  12. Christian CouderJan 29, 2021
  13. 2/7 bisect--helper: reimplement `bisect_replay` shell function in CMiriam Rubio, Jan 25, 2021
  14. Christian CouderJan 29, 2021
  15. Junio C HamanoJan 26, 2021
  16. Miriam R.Jan 26, 2021
  17. Junio C HamanoJan 26, 2021
  18. Junio C HamanoJan 26, 2021
  19. Miriam R.Jan 27, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.