Re: [PATCH v4 2/7] bisect--helper: reimplement `bisect_replay` shell function in C

From: Christian Couder <christian.couder@gmail.com>
Date: Jan 29, 2021, 07:51 UTC
Message-ID: <CAP8UFD2qK2BmdjLnaMzvdyMnr7Xi8phe2GhiCMsj5qNx9pTM-w@mail.gmail.com>
In-Reply-To: <20210125191710.45161-3-mirucam@gmail.com>

On Mon, Jan 25, 2021 at 8:17 PM Miriam Rubio <mirucam@gmail.com> wrote:

> +       while ((strbuf_getline(&line, fp) != EOF) && !res){

It looks like a space char is missing between ")" and "{"...

> +               res = process_replay_line(terms, &line);
> +       }

...but as there is only one line in the {...}, we could just get rid of the block like this:

       while ((strbuf_getline(&line, fp) != EOF) && !res)
               res = process_replay_line(terms, &line);

Best, Christian.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.