Re: [PATCH v4 4/7] bisect--helper: use `res` instead of return in BISECT_RESET case option

From: Christian Couder <christian.couder@gmail.com>
Date: Jan 29, 2021, 07:57 UTC
Message-ID: <CAP8UFD0mezb35u3SPi2Q2w-oCfA8NYAmacropNQQHumC7Vdkxg@mail.gmail.com>
In-Reply-To: <20210125191710.45161-5-mirucam@gmail.com>

On Mon, Jan 25, 2021 at 8:17 PM Miriam Rubio <mirucam@gmail.com> wrote:

Show 7 quoted lines

> @@ -1043,7 +1043,7 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
>         case BISECT_RESET:
>                 if (argc > 1)
>                         return error(_("--bisect-reset requires either no argument or a commit"));
> -               return !!bisect_reset(argc ? argv[0] : NULL);
> +               res = bisect_reset(argc ? argv[0] : NULL);
>                 break;

This "break;" was not necessary before but it becomes necessary when the above "return ..." is replaced with something else.

>         case CHECK_AND_SET_TERMS:
>                 if (argc != 3)