Re: [PATCH v3 1/6] credential-cache{,--daemon}: don't build under NO_UNIX_SOCKETS

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 12, 2021, 21:48 UTC
Message-ID: <xmqqczpdlb2s.fsf@gitster.g>
In-Reply-To: <patch-v3-1.6-ad857e80fd8-20210911T190239Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 5 quoted lines

> @@ -1693,6 +1695,7 @@ ifdef NO_INET_PTON
>  endif
>  ifdef NO_UNIX_SOCKETS
>  	BASIC_CFLAGS += -DNO_UNIX_SOCKETS
> +	EXCLUDED_PROGRAMS += git-credential-cache git-credential-cache--daemon

Yah, I forgot about EXCLUDED_PROGRAMS ;-)

Sounds like a sensible direction to go.

Show 15 quoted lines

> diff --git a/git.c b/git.c
> index 18bed9a9964..7c696e06ecf 100644
> --- a/git.c
> +++ b/git.c
> @@ -513,8 +513,10 @@ static struct cmd_struct commands[] = {
>  	{ "config", cmd_config, RUN_SETUP_GENTLY | DELAY_PAGER_CONFIG },
>  	{ "count-objects", cmd_count_objects, RUN_SETUP },
>  	{ "credential", cmd_credential, RUN_SETUP_GENTLY | NO_PARSEOPT },
> +#ifndef NO_UNIX_SOCKETS
>  	{ "credential-cache", cmd_credential_cache },
>  	{ "credential-cache--daemon", cmd_credential_cache_daemon },
> +#endif
>  	{ "credential-store", cmd_credential_store },
>  	{ "describe", cmd_describe, RUN_SETUP },
>  	{ "diff", cmd_diff, NO_PARSEOPT },

OK.  Looks good.