Re: [PATCH v2 0/6] parse-options: properly align continued usage output & related

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 11, 2021, 07:41 UTC
Message-ID: <CAPig+cSrjx=okjqyOtD7=wwcAt2QZ30OMr8rKNoy9Z42_Ux4ew@mail.gmail.com>
In-Reply-To: <cover-v2-0.6-00000000000-20210910T153146Z-avarab@gmail.com>

On Fri, Sep 10, 2021 at 11:38 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 7 quoted lines

> This series changes usage_with_options_internal() in parse-options.c
> to properly align continued "\n" usage output.
>
> This v2 now also gets rid of the support for "" in the usage string
> array. Eric Sunshine had ideas[1] for how to simplify the code in v1,
> along with a suggestion that we could just get rid of the "" from
> "builtin/blame.c".

To be clear, I only asked whether you really needed to add support for embedded newlines in free-form usage strings following a "" line; I didn't actually suggest dropping support for free-form text following a "" line. Perhaps I didn't articulate that well enough, though, in my review(?).

Aside: I did, however, _think_ about suggesting that free-form text
support be dropped since I only found one consumer of the feature,
however, I decided not to make that suggestion since the feature
seemed like it had potential value and the current implementation is
good enough and simple enough (though undocumented, as far as I can
tell).