Re: [PATCH v2 2/6] git.c: add a NEED_UNIX_SOCKETS option for built-ins

From: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date: Sep 11, 2021, 03:47 UTC
Message-ID: <YTwm57pp/cvfR5rg@carlos-mbp.lan>
In-Reply-To: <87mtojaklj.fsf@evledraar.gmail.com>

Sorry, if this is silly, but why is this not better (at least as a starting point, since it obviously will need more work?

Undefined symbols for architecture x86_64:
  "_cmd_credential_cache", referenced from:
      _commands in git.o
  "_cmd_credential_cache_daemon", referenced from:
      _commands in git.o

Carlo ---- >8 ----

diff --git a/Makefile b/Makefile
index 44734f916a..2a60685c37 100644
--- a/Makefile
+++ b/Makefile
@@ -1098,8 +1098,10 @@ BUILTIN_OBJS += builtin/commit-tree.o
 BUILTIN_OBJS += builtin/commit.o
 BUILTIN_OBJS += builtin/config.o
 BUILTIN_OBJS += builtin/count-objects.o
+ifndef NO_UNIX_SOCKETS
 BUILTIN_OBJS += builtin/credential-cache--daemon.o
 BUILTIN_OBJS += builtin/credential-cache.o
+endif
 BUILTIN_OBJS += builtin/credential-store.o
 BUILTIN_OBJS += builtin/credential.o
 BUILTIN_OBJS += builtin/describe.o