Re: [PATCH v2 0/4] gitlab-ci: fix the cargo invocation in the Windows job
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 28, 2026, 14:26 UTC
- Message-ID
- <xmqqcxtxpi3p.fsf@gitster.g>
- In-Reply-To
- <aroOHoSXsemSlP-7@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 21 quoted lines
> On Thu, Sep 24, 2026 at 08:01:49PM +0000, Johannes Schindelin via GitGitGadget wrote: >> Range-diff vs v1: >> >> 1: 6a389b2bad ! 1: cdf2eff480 ci(gitlab,windows): provision GNU Rust for SDK-based MinGW builds >> @@ Metadata >> ## Commit message ## >> ci(gitlab,windows): provision GNU Rust for SDK-based MinGW builds >> >> - The minimal Git for Windows SDK already supplies Git and GCC. The >> - MinGW Makefile build needs the GNU Rust toolchain, not another Git >> - installation or Meson. >> + The minimal Git for Windows SDK already supplies Git and GCC. The MinGW >> + Makefile build needs the Rust toolchain that targets GCC (as opposed to >> + the more common MSVC one), not another Git installation or Meson. > > By the way, are there plans to eventually include Rust as part of the > GfW SDK? Just asking out of curiosity. > > Overall I'm happy with this version, thanks! > > Patrick
Thanks for writing and reviewing, both of you. Let me mark the topic for 'next'.